On 2014/12/10 14:22:14, caitp wrote:
On 2014/12/10 14:20:19, Diego Pino wrote:
> On 2014/12/10 13:36:25, rossberg wrote:
>
> > I'm curious to know what crash you got. Your version looks correct,
too,
but
> > it's a bit more expensive.
>
> I added ToLengthFlagged() to src/array.js and redefined it in
> src/harmomy-array.js as:
>
> function ToLengthFlagged(length) {
> return ToLength(length);
> }
>
> I put that code at the very beginning of the file, right before the
definition
> of 'ArrayFind'.
>
> Then if I try to run the new tests or simply start d8 --harmony_array,
I got
the
> following crash:
>
> $ d8 --harmony_arrays
> Exception thrown during bootstrapping
> Extension or internal compilation error.
> Failing script:
> Exception thrown during bootstrapping
> Extension or internal compilation error.
> 1: Failing script:
> 1:
>
> #
> # Fatal error in .././src/api.h, line 386
> # CHECK(allow_empty_handle || that != __null) failed
> #
>
> ==== C stack trace ===============================
>
> 1: ??
> 2: ??
> 3: ??
> 4: ??
> 5: ??
> 6: ??
> 7: __libc_start_main
> 8: ??
> Illegal instruction (core dumped)
>
> This is a backtrace of the crash:
>
> (gdb) bt
> #0 0x00000000008bca29 in v8::base::OS::Abort() ()
> #1 0x00000000008baf6e in V8_Fatal ()
> #2 0x0000000000418078 in v8::Utils::OpenHandle(v8::Context const*,
bool) ()
> #3 0x0000000000418ec5 in v8::Context::Enter() ()
> #4 0x000000000040b44f in
v8::Shell::CreateEvaluationContext(v8::Isolate*)
()
> #5 0x000000000040c783 in v8::Shell::RunMain(v8::Isolate*, int, char**)
()
> #6 0x0000000000410dc4 in v8::Shell::Main(int, char**) ()
> #7 0x00007fa8ef450ec5 in __libc_start_main (main=0x407db0 <main>,
argc=2,
> argv=0x7fff6f017678, init=<optimized out>, fini=<optimized out>,
> rtld_fini=<optimized out>, stack_end=0x7fff6f017668) at
libc-start.c:287
>
> My environment is Ubuntu 14.04, x86_64, gcc (Ubuntu 4.8.2-19ubuntu1)
4.8.2.
>
> I created a gist of the patch
https://gist.github.com/dpino/30587a3cbf7acd71fc98
Ah, that is the effect you get when some of the library JavaScript failed at
start-up. It looks more scary than it is (but admittedly isn't very helpful
either).
To be honest, though, I'm not quite sure what the error is here.
Try `var ToLengthFlagged = ToUint32;` in array.js, and `ToLengthFlagged =
ToLength;` in harmony-array.js
That should avoid the problem
Right, that's what I had in mind. Could you try that?
https://codereview.chromium.org/553623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
