Getting there.
I just noticed the test's name: "monorphic" is not a word, and even if you
correct the typo, "generic-monomorphic" is contradictory and confusing.
Suggestion: "keyed-load-with-string-key.js"
https://codereview.chromium.org/755513003/diff/60001/src/ic/ic-compiler.cc
File src/ic/ic-compiler.cc (right):
https://codereview.chromium.org/755513003/diff/60001/src/ic/ic-compiler.cc#newcode91
src/ic/ic-compiler.cc:91: ExtraICState extra_ic_state) {
If you insist on keeping this additional argument, please explain to me
in which cases it changes anything. I still don't think we need it, and
I don't like adding extra code and extra parameters that don't do
anything.
(Same below in the polymorphic case.)
https://codereview.chromium.org/755513003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
