Hm... I understand the idea, but don't get what you want me to do in
practice.
What I'm saying is: this code shouldn't change behavior, and doesn't need
to be
modified, so don't modify it, especially not by making changes that don't do
anything. Just keep it the way it was.
Should it just use not use extra_ic_state in these functions at all? This
will
work because ELEMENT is equal to 0 at the moment, and that bit in extra
state
is
0 by default, but isn't it a bit incorrect?
It's perfectly correct. Feel free to add a STATIC_ASSERT(ELEMENT ==
kNoExtraICState) if you want to guard against future changes. However the
most
likely future change is that all of this code will be ripped out and
replaced by
vector ICs, which handle things differently (and much more cleanly) anyway.
https://codereview.chromium.org/755513003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
