https://codereview.chromium.org/755513003/diff/60001/src/ic/ic-compiler.cc
File src/ic/ic-compiler.cc (right):
https://codereview.chromium.org/755513003/diff/60001/src/ic/ic-compiler.cc#newcode91
src/ic/ic-compiler.cc:91: ExtraICState extra_ic_state) {
On 2014/12/12 13:05:37, indutny wrote:
On 2014/12/12 10:14:27, Jakob wrote:
> If you insist on keeping this additional argument, please explain to
me in
which
> cases it changes anything. I still don't think we need it, and I
don't like
> adding extra code and extra parameters that don't do anything.
> (Same below in the polymorphic case.)
I'd either need to pass this, or StrictMode to be able to generate
extra_ic_state here. Which do you prefer?
Why do you need StrictMode? Loads don't depend on strict mode. We didn't
need to pass in anything before, and we don't want to change behavior
for element loads (or the way their stubs are
compiled/cached/retrieved), and we also don't want to toggle that bit
arbitrarily: valid transitions are uninitialized -> ELEMENT -> generic
and uninitialized -> PROPERTY -> generic, but never ELEMENT -> PROPERTY
-> ELEMENT -> PROPERTY -> etc.
So why would we need to pass in anything now?
https://codereview.chromium.org/755513003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
