PTAL
https://codereview.chromium.org/811113002/diff/1/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/811113002/diff/1/src/scanner.cc#newcode706
src/scanner.cc:706: if (!in_template_literal && c0_ >= 0 &&
unicode_cache_->IsLineTerminator(c)) {
On 2014/12/17 17:04:21, caitp wrote:
Is this check necessary? I think ScanTemplateSpan will not invoke
ScanEscape for
line continuations --- fine to add it but I'm not sure it's needed
It is not needed but it is dead code in case we are in a template
literal.
https://codereview.chromium.org/811113002/diff/1/src/scanner.cc#newcode851
src/scanner.cc:851: ScanEscape<capture_raw, in_template_literal>();
On 2014/12/17 17:04:21, caitp wrote:
How are these ever not <true, true> here?
They are always true, true here. I added the const var for readability.
I still want to try to only capture raw when we are in a tagged literal
so I decided to introduce one more template param instead of conflating
this.
https://codereview.chromium.org/811113002/diff/1/test/mjsunit/harmony/templates.js
File test/mjsunit/harmony/templates.js (right):
https://codereview.chromium.org/811113002/diff/1/test/mjsunit/harmony/templates.js#newcode477
test/mjsunit/harmony/templates.js:477: assertEquals('0', `\0`);
On 2014/12/17 17:06:03, caitp wrote:
On 2014/12/17 17:04:21, caitp wrote:
> > The CV of EscapeSequence :: 0 is the code unit value 0.
>
> Does this not basically make this U+0000 rather than U+0030? (I
might be
> misunderstanding it)
In SpiderMonkey, it is U+0000
Fixed.
https://codereview.chromium.org/811113002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
