Lgtm, few things though
https://codereview.chromium.org/811113002/diff/40001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/811113002/diff/40001/src/scanner.cc#newcode739
src/scanner.cc:739: return false;
I feel like we should just let ScanOctalEscape do its thing and use
CheckOctalLiteral() in the preparser, instead of this (better error
message).
I don't think that's a blocker though
https://codereview.chromium.org/811113002/diff/40001/test/mjsunit/harmony/templates.js
File test/mjsunit/harmony/templates.js (left):
https://codereview.chromium.org/811113002/diff/40001/test/mjsunit/harmony/templates.js#oldcode256
test/mjsunit/harmony/templates.js:256: (function(s) { calls++;
assertEquals("\u005Cx", s.raw[0]); })`\x`;
Maybe just replace `\x` with `\z` or something?
https://codereview.chromium.org/811113002/diff/40001/test/mjsunit/harmony/templates.js
File test/mjsunit/harmony/templates.js (right):
https://codereview.chromium.org/811113002/diff/40001/test/mjsunit/harmony/templates.js#newcode475
test/mjsunit/harmony/templates.js:475: assertThrows("`\\01`",
SyntaxError);
This looks like a duplicate
\00, \01, \02, \03, \04, \05, \06, \07, \08, and \09 should all be
errors --- but \0a, \0., \0^ etc should all be okay.
https://codereview.chromium.org/811113002/diff/40001/test/mjsunit/harmony/templates.js#newcode478
test/mjsunit/harmony/templates.js:478: assertEquals('\\123',
String.raw`\123`);
My reading of the spec is that this should be a SyntaxError as well
https://codereview.chromium.org/811113002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
