https://codereview.chromium.org/811113002/diff/80001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/811113002/diff/80001/src/scanner.cc#newcode730
src/scanner.cc:730: break;
On 2014/12/17 20:32:14, caitp wrote:
Was this added changed by accident? not a big deal though
git cl format complained...
https://codereview.chromium.org/811113002/diff/80001/src/scanner.cc#newcode738
src/scanner.cc:738: // \ 0 DecimalDigit is never allowed in templates.
On 2014/12/17 20:32:14, caitp wrote:
It's not really restricted to templates, this applies to strict-mode
string
literals as well. I did some experimenting with this, and it looks
like JSC is
the only engine that is doing this right. Bug filed on SM at
https://bugzilla.mozilla.org/show_bug.cgi?id=1112732 (although it may
or may not
be really fixable depending on how much it's used in the wild)
I can submit a followup for fixing this, but I don't really know how
much it
would break the web
We talked about legacy octal numbers at a recent TC39
https://github.com/rwaldron/tc39-notes/blob/b26f950b438b18ac3497fd717dfb2370a84f7fb3/es6/2014-09/sept-23.md#43-legacy-decimal-integer-literals-starting-with-0-and-containing-8-or-9
The conclusion covers '\08'.
https://codereview.chromium.org/811113002/diff/80001/test/mjsunit/harmony/templates.js
File test/mjsunit/harmony/templates.js (right):
https://codereview.chromium.org/811113002/diff/80001/test/mjsunit/harmony/templates.js#newcode480
test/mjsunit/harmony/templates.js:480: assertThrows(code, SyntaxError);
On 2014/12/17 20:32:14, caitp wrote:
I think it would be good to also test `\0<nondigitcharacters>`, or at
least one
such test
Done.
https://codereview.chromium.org/811113002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
