http://codereview.chromium.org/293023/diff/1043/58 File src/runtime.cc (right):
http://codereview.chromium.org/293023/diff/1043/58#newcode2583 Line 2583: // If the target object is a JSObject and has an ExternalArray as On 2009/10/20 14:54:10, Christian Plesner Hansen wrote: > What happens if you get -1 represented as a heap number? There's no guarantee > that integers in smi range will be represented as smis. Probably we will silently drop the operation on the floor rather than throwing an exception because Array::IndexFromObject will return false, and these objects don't support adding arbitrary keys. This is what was happening before I added this explicit check. http://codereview.chromium.org/293023 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
