http://codereview.chromium.org/293023/diff/5013/4029 File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/293023/diff/5013/4029#newcode1261 Line 1261: emit_rex_32(src, dst); On 2009/10/20 15:09:47, William Hesse wrote: > Use emit_optional_rex_32. > Ox66 prefix goes before REX. Done. http://codereview.chromium.org/293023/diff/5013/4029#newcode1512 Line 1512: emit_rex_64(dst, src); On 2009/10/20 15:09:47, William Hesse wrote: > I don't think this is needed. Wouldn't the write to the 32-bit register also > zero out the top 32 bits? I think this should be optional_rex_32, and should be > the exact same code as movzxwl. In fact, it should just be an inlined call to > movzxwl. Not sure. Based on our conversation just now I'm going to leave this as is -- the emission of this instruction is being tested by the code I will send out for review next and it seems to be working. http://codereview.chromium.org/293023 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
