On 2015/01/09 17:10:08, caitp wrote:
https://codereview.chromium.org/816913003/diff/80001/test/mjsunit/harmony/rest-params.js
File test/mjsunit/harmony/rest-params.js (right):
https://codereview.chromium.org/816913003/diff/80001/test/mjsunit/harmony/rest-params.js#newcode16
test/mjsunit/harmony/rest-params.js:16: //assertEquals(c[j++],
arguments[i]);
On 2015/01/09 17:01:59, arv wrote:
> ?
>
> Is this not working yet?
I thought I uncommented this, guess I forgot.
The issue here is, arguments[...] accesses look for the value on the
stack,
for
whatever reason. So, since the value on the stack was replaced with an
array,
it
gives the wrong value for the index of the rest parameter.
The document I posted earlier covers a few ways to work around this, I'm
just
not sure what is the right approach to take here.
solved the one issue with arguments values being clobbered.
Function arity is reported incorrectly under some circumstances, and it's
hard
to see why (doesn't seem to happen from full-codegen tests) --- also, I find
that I hit an assertion somewhere if I do something like `function(a,
b, ...c) {
return { args: [].slice.call(arguments), rest: c }; }`, it's hard to make
this
work right :>
https://codereview.chromium.org/816913003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
