Good things:
- bailout of hydrogen if rest parameters are present
- basic implementation in turbofan that seems to work well
- try to always produce strict/unmapped arguments objects when rest params
used
- make sure function length is always set correctly
Bad things:
- there is a distinction between "rest arguments used" and "rest arguments
in
formal parameters" --- there probably doesn't need to be such a
distinction, and
working around it is kind of awkward
- for whatever reason, under certain conditions, sloppy arguments are still
produced (resulting in some failing tests which try to assert that the
arguments
object is unmapped) --- however during manual testing (with various
optimization
flags) it seems to work correctly
- the whole "is_simple_parameter_list()" thing is very messy and probably
shows
up in more places than is really needed
but, it's getting there :> I think all tests should pass once unmapped
arguments
are being generated in all cases, just need to figure out why they're not.
https://codereview.chromium.org/816913003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
