https://codereview.chromium.org/867153003/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/867153003/diff/1/src/objects.h#newcode7192
src/objects.h:7192: kIsSublclassConstructor,
typo
https://codereview.chromium.org/867153003/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/867153003/diff/1/src/parser.cc#newcode274
src/parser.cc:274: (FLAG_experimental_classes &&
IsSubclassConstructor(kind)) ? true : false;
bool uninitialized_this = FLAG_experimental_classes &&
IsSubclassConstructor(kind);
https://codereview.chromium.org/867153003/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/867153003/diff/1/src/runtime/runtime-classes.cc#newcode112
src/runtime/runtime-classes.cc:112: Handle<Code>
stub(isolate->builtins()->JSConstructStubForDerived());
Let me make sure I understand this correctly. We replace the normal
construct stub with one that understands NewTarget.
This makes me think I should use stubs for the default constructors too.
https://codereview.chromium.org/867153003/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/867153003/diff/1/test/cctest/test-parsing.cc#newcode3111
test/cctest/test-parsing.cc:3111: script_scope->Initialize(false);
maybe even use a default param here since this false value gives no
hint.
https://codereview.chromium.org/867153003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
