Comments addressed.
https://codereview.chromium.org/867153003/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/867153003/diff/1/src/objects.h#newcode7192
src/objects.h:7192: kIsSublclassConstructor,
On 2015/01/23 15:40:46, arv wrote:
typo
Done.
https://codereview.chromium.org/867153003/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/867153003/diff/1/src/parser.cc#newcode274
src/parser.cc:274: (FLAG_experimental_classes &&
IsSubclassConstructor(kind)) ? true : false;
On 2015/01/23 15:40:46, arv wrote:
bool uninitialized_this = FLAG_experimental_classes &&
IsSubclassConstructor(kind);
Done (classic!)
https://codereview.chromium.org/867153003/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/867153003/diff/1/src/runtime/runtime-classes.cc#newcode112
src/runtime/runtime-classes.cc:112: Handle<Code>
stub(isolate->builtins()->JSConstructStubForDerived());
On 2015/01/23 15:40:46, arv wrote:
Let me make sure I understand this correctly. We replace the normal
construct
stub with one that understands NewTarget.
Correct, although none of stubs yet understand new.target.
They both will eventually (soon).
JSConstructStubForDerived is the one that does not allocate and passes a
hole as receiver.
This makes me think I should use stubs for the default constructors
too.
Correct.
Yes, this patch does not cover default constructors. If you want I can
handle stubs for them here (although I'd prefer a separate patch)
https://codereview.chromium.org/867153003/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/867153003/diff/1/test/cctest/test-parsing.cc#newcode3111
test/cctest/test-parsing.cc:3111: script_scope->Initialize(false);
On 2015/01/23 15:40:46, arv wrote:
maybe even use a default param here since this false value gives no
hint.
Done.
https://codereview.chromium.org/867153003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
