PTAL
https://codereview.chromium.org/867153003/diff/80001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/867153003/diff/80001/src/ia32/full-codegen-ia32.cc#newcode1463
src/ia32/full-codegen-ia32.cc:1463: } else if (var->is_this()) {
On 2015/02/02 16:32:37, rossberg wrote:
Does this now affect every use of 'this'? Can we limit the check to
actual
constructors?
No, this only happens if var->binding_needs_init() and `this` does not
need intitalization outside of subclass constructors. Added an assert.
https://codereview.chromium.org/867153003/diff/80001/src/preparser.cc
File src/preparser.cc (right):
https://codereview.chromium.org/867153003/diff/80001/src/preparser.cc#newcode982
src/preparser.cc:982: bool has_extends = false;
On 2015/02/02 16:32:38, rossberg wrote:
Nit:
bool has_extends = Check(Token::EXTENDS);
if (has_extends) ParseLeftHandSideExpression(CHECK_OK);
Done.
https://codereview.chromium.org/867153003/diff/80001/test/mjsunit/harmony/classes-experimental.js
File test/mjsunit/harmony/classes-experimental.js (right):
https://codereview.chromium.org/867153003/diff/80001/test/mjsunit/harmony/classes-experimental.js#newcode48
test/mjsunit/harmony/classes-experimental.js:48: var exn = null;
On 2015/01/27 21:08:27, arv wrote:
any reason why you are using var here and let above?
Done.
https://codereview.chromium.org/867153003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
