lgtm
https://codereview.chromium.org/879553002/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/879553002/diff/1/include/v8.h#newcode980
include/v8.h:980: Handle<Boolean> resource_is_internal_script =
Handle<Boolean>())
The "internal" term is somewhat confusing. Can we rename to something
like is_debugger_script?
https://codereview.chromium.org/879553002/diff/1/include/v8.h#newcode990
include/v8.h:990: V8_INLINE Handle<Boolean> ResourceIsInternalScript()
const;
Can you add a comment to the method describing meaning of the flag?
https://codereview.chromium.org/879553002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/879553002/diff/1/src/api.cc#newcode1573
src/api.cc:1573: source->resource_is_internal_script ==
v8::True(v8_isolate);
source->resource_is_internal_script->IsTrue()
https://codereview.chromium.org/879553002/diff/1/src/api.cc#newcode1661
src/api.cc:1661:
script->set_is_internal_script(origin.ResourceIsInternalScript() ==
ditto
https://codereview.chromium.org/879553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
