https://codereview.chromium.org/879553002/diff/40001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/879553002/diff/40001/include/v8.h#newcode991
include/v8.h:991: * Returns true for embdedder's debugger scripts
On 2015/01/26 23:51:17, info1 wrote:
Typo: s/embdedder/embedder/
From the diff, it's not clear to me why it's called something
something
debugger, it doesn't seem debug related at all. Maybe 'builtin' or
'native' is
a better name?
Done.
I suppose that bultin and native is not better name. This flag added for
DevTools, we need to mark some scripts as internal. From DevTools side
this flag can be called as isDebuggerScript. I understood that from V8
side this name is not correct. Maybe add embedder to name:
isEmbedderInternalScript is better.
https://codereview.chromium.org/879553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
