https://codereview.chromium.org/879553002/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/879553002/diff/1/include/v8.h#newcode980
include/v8.h:980: Handle<Boolean> resource_is_internal_script =
Handle<Boolean>())
On 2015/01/26 15:41:06, yurys wrote:
The "internal" term is somewhat confusing. Can we rename to something
like
is_debugger_script?
Done.
https://codereview.chromium.org/879553002/diff/1/include/v8.h#newcode984
include/v8.h:984:
resource_is_internal_script_(resource_is_internal_script),
On 2015/01/26 15:46:43, yurys wrote:
Would it make sense to have something like
Script::SetDebugData(Handle<Value>)
and keep flags like that in such object?
Acknowledged.
https://codereview.chromium.org/879553002/diff/1/include/v8.h#newcode990
include/v8.h:990: V8_INLINE Handle<Boolean> ResourceIsInternalScript()
const;
On 2015/01/26 15:41:05, yurys wrote:
Can you add a comment to the method describing meaning of the flag?
Done.
https://codereview.chromium.org/879553002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/879553002/diff/1/src/api.cc#newcode1573
src/api.cc:1573: source->resource_is_internal_script ==
v8::True(v8_isolate);
On 2015/01/26 15:41:06, yurys wrote:
source->resource_is_internal_script->IsTrue()
Done.
https://codereview.chromium.org/879553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
