Please take another look

https://codereview.chromium.org/897883002/diff/40001/src/compiler/simplified-lowering.cc
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/897883002/diff/40001/src/compiler/simplified-lowering.cc#newcode98
src/compiler/simplified-lowering.cc:98: SourcePositionTable::Scope
scope(
On 2015/02/04 13:23:44, titzer wrote:
You shouldn't need the scope during the propagation phase.

Done.

https://codereview.chromium.org/897883002/diff/40001/src/compiler/simplified-lowering.cc#newcode462
src/compiler/simplified-lowering.cc:462: void VisitNode(Node* node,
MachineTypeUnion use,
On 2015/02/04 13:23:44, titzer wrote:
I'd rather see this inlined into the second loop (or two loop
versions) in the
Run() method, since it's not needed during propagation.

Done.

https://codereview.chromium.org/897883002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to