LGTM with comments. I looked at everything outside of simplified lowering,
I'll
leave that to Ben.
https://codereview.chromium.org/897883002/diff/60001/src/compiler/graph.cc
File src/compiler/graph.cc (right):
https://codereview.chromium.org/897883002/diff/60001/src/compiler/graph.cc#newcode27
src/compiler/graph.cc:27: decorator->Decorate(node, incomplete);
nit: Can we put curly braces around the body?
https://codereview.chromium.org/897883002/diff/60001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/897883002/diff/60001/src/compiler/pipeline.cc#newcode349
src/compiler/pipeline.cc:349: SourcePositionWrapper* wrapper = new
(data->graph_zone())
According to Benedikt we should use the existing placement operator
instead of overriding it ...
void* buffer = zone->New(sizeof(SourcePositionWrapper));
SourcePositionWrapper* wrapper =
new(buffer) SourcePositionWrapper(reducer,
data->source_positions());
https://codereview.chromium.org/897883002/diff/60001/src/compiler/pipeline.cc#newcode356
src/compiler/pipeline.cc:356: };
nit: Can we add "// namespace", also semi-colon seems redundant.
https://codereview.chromium.org/897883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
