Please take another look
https://codereview.chromium.org/897883002/diff/60001/src/compiler/graph.cc
File src/compiler/graph.cc (right):
https://codereview.chromium.org/897883002/diff/60001/src/compiler/graph.cc#newcode27
src/compiler/graph.cc:27: decorator->Decorate(node, incomplete);
On 2015/02/04 13:54:03, Michael Starzinger wrote:
nit: Can we put curly braces around the body?
Done.
https://codereview.chromium.org/897883002/diff/60001/src/compiler/graph.h
File src/compiler/graph.h (right):
https://codereview.chromium.org/897883002/diff/60001/src/compiler/graph.h#newcode85
src/compiler/graph.h:85: void Decorate(Node* node, bool incomplete);
On 2015/02/04 13:46:19, titzer wrote:
Is this incomplete flag necessary for source positions? Seems like
there is an
unrelated change to the typer included in this CL.
Nope, this is intended. Note that previously Decorators were not called
when nodes were incomplete. This was because the typer didn't want to
type some "incomplete" nodes. However, the source position decorator
_always_ wants to be invoked, even for incomplete nodes.
https://codereview.chromium.org/897883002/diff/60001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/897883002/diff/60001/src/compiler/pipeline.cc#newcode349
src/compiler/pipeline.cc:349: SourcePositionWrapper* wrapper = new
(data->graph_zone())
On 2015/02/04 13:54:03, Michael Starzinger wrote:
According to Benedikt we should use the existing placement operator
instead of
overriding it ...
void* buffer = zone->New(sizeof(SourcePositionWrapper));
SourcePositionWrapper* wrapper =
new(buffer) SourcePositionWrapper(reducer,
data->source_positions());
Done.
https://codereview.chromium.org/897883002/diff/60001/src/compiler/pipeline.cc#newcode356
src/compiler/pipeline.cc:356: };
On 2015/02/04 13:54:03, Michael Starzinger wrote:
nit: Can we add "// namespace", also semi-colon seems redundant.
Done.
https://codereview.chromium.org/897883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
