On Sat, Oct 31, 2009 at 9:20 PM, <[email protected]> wrote: > > http://codereview.chromium.org/342058/diff/1/3 > File src/ia32/fast-codegen-ia32.cc (right): > > http://codereview.chromium.org/342058/diff/1/3#newcode937 > Line 937: ASSERT(v->AsVariable() != NULL && v->AsVariable() != NULL); > I'm not sure what you intended the other half of this assert to be. > > If the assert is a conjunction, we usually write it as separate asserts > so it's easy to see which one failed. > > Oh - yes. I should write
ASSERT(v->AsVariable() != NULL); ASSERT(v->AsVariable()->is_global()); I fixed that on all platforms. > > http://codereview.chromium.org/342058 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
