Also like it, though I just took a superficial glance. A few suggestions
below.
https://codereview.chromium.org/974213002/diff/1/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/974213002/diff/1/src/globals.h#newcode457
src/globals.h:457: enum ParseRestriction {
I don't think this belongs into global.h - it encodes a choice of start
symbol for parsing. In that sense, it has a similar role to flags like
parse_info->is_module(), and should probably be handled analogously.
I.e., just kill the enum and have a is_function flag in parse info. (And
later we should probably unify these flags into one grammar_entry kind
of value.)
Short of that, can you at least move it to parser.h?
https://codereview.chromium.org/974213002/diff/1/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/974213002/diff/1/src/parser.h#newcode75
src/parser.h:75: enum Flag {
Can we make the enum private?
https://codereview.chromium.org/974213002/diff/1/src/parser.h#newcode216
src/parser.h:216: //------------- Inputs to parsing and scope analysis
-----------------------
Nit: Would be even more useful to have these sectioning comments on the
accessors in the public part of the class.
https://codereview.chromium.org/974213002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
