moar comments
https://codereview.chromium.org/974213002/diff/80001/src/background-parsing-task.cc
File src/background-parsing-task.cc (right):
https://codereview.chromium.org/974213002/diff/80001/src/background-parsing-task.cc#newcode31
src/background-parsing-task.cc:31: bool disable_lazy =
!Compiler::DebuggerWantsEagerCompilation(isolate);
... shouldn't we disable_lazy exactly when
DebuggerWantsEagerCompilation, without negation?
https://codereview.chromium.org/974213002/diff/80001/src/background-parsing-task.cc#newcode39
src/background-parsing-task.cc:39: source->allow_lazy = !disable_lazy;
... and why do we need allow_lazy now that it's already known by info?
https://codereview.chromium.org/974213002/diff/80001/src/background-parsing-task.h
File src/background-parsing-task.h (right):
https://codereview.chromium.org/974213002/diff/80001/src/background-parsing-task.h#newcode38
src/background-parsing-task.h:38: SmartPointer<Zone> zone;
Why is Zone needed separately, can't we get it from ParseInfo?
https://codereview.chromium.org/974213002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
