Just ia32 for now
https://codereview.chromium.org/988653003/diff/60001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/988653003/diff/60001/src/code-stubs-hydrogen.cc#newcode117
src/code-stubs-hydrogen.cc:117: void HandleMonoCase(HValue* weak_cell,
HValue* receiver, HValue* name,
HandleMonomorphicCase
https://codereview.chromium.org/988653003/diff/60001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/988653003/diff/60001/src/ia32/code-stubs-ia32.cc#newcode4438
src/ia32/code-stubs-ia32.cc:4438: __ mov(feedback,
FieldOperand(feedback, FixedArray::OffsetOfElementAt(1)));
feedback -> handler?
Maybe just do Register handler = feedback;
https://codereview.chromium.org/988653003/diff/60001/src/ia32/code-stubs-ia32.cc#newcode4446
src/ia32/code-stubs-ia32.cc:4446: Immediate(Smi::FromInt(2)));
This isn't possible for named loads afaict.
https://codereview.chromium.org/988653003/diff/60001/src/ia32/code-stubs-ia32.cc#newcode4455
src/ia32/code-stubs-ia32.cc:4455: __ push(key);
As discussed, you don't need the key for named loads if you store it the
next to the feedback array on top-level; so you don't need to spill it.
https://codereview.chromium.org/988653003/diff/60001/src/ia32/code-stubs-ia32.cc#newcode4499
src/ia32/code-stubs-ia32.cc:4499: __ cmp(weak_cell,
FieldOperand(receiver, 0));
Register receiver_map = weak_cell;
https://codereview.chromium.org/988653003/diff/60001/src/ia32/code-stubs-ia32.cc#newcode4501
src/ia32/code-stubs-ia32.cc:4501: __ mov(weak_cell, FieldOperand(vector,
slot, times_half_pointer_size,
Register code_object = weak_cell;
https://codereview.chromium.org/988653003/diff/60001/src/ia32/code-stubs-ia32.cc#newcode4617
src/ia32/code-stubs-ia32.cc:4617: __ int3(); // We shouldn't get here.
drop int3(), I presume we can trust __jmp to do the right thing :)
https://codereview.chromium.org/988653003/diff/60001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/988653003/diff/60001/src/objects.h#newcode8804
src/objects.h:8804: static const int kFlagsOffset = Name::kSize;
Is this still necessary?
[At this point haven't looked at platform specific files yet, but I seem
to recall that this idea was discarded]
https://codereview.chromium.org/988653003/diff/60001/src/type-feedback-vector.cc
File src/type-feedback-vector.cc (right):
https://codereview.chromium.org/988653003/diff/60001/src/type-feedback-vector.cc#newcode214
src/type-feedback-vector.cc:214:
FixedArray::cast(*feedback_extra)->length() != length) {
< ?
https://codereview.chromium.org/988653003/diff/60001/src/type-feedback-vector.h
File src/type-feedback-vector.h (right):
https://codereview.chromium.org/988653003/diff/60001/src/type-feedback-vector.h#newcode284
src/type-feedback-vector.h:284: int ExtractMapsImpl(MapHandleList* maps)
const;
Impl?
https://codereview.chromium.org/988653003/diff/60001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/988653003/diff/60001/src/x64/code-stubs-x64.cc#newcode4489
src/x64/code-stubs-x64.cc:4489: __ int3(); // We shouldn't get here.
Same here
https://codereview.chromium.org/988653003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
