Looking great.
Some final comments; we discussed all of them offline.
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4389
src/x64/code-stubs-x64.cc:4389: __ cmpp(length, Immediate(2));
cmpl, since SmiToInteger32 above does movl of the payload
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4392
src/x64/code-stubs-x64.cc:4392: __ movp(counter, Immediate(2));
perhaps there's a shorter sequence to get a 0-extended 2?
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4395
src/x64/code-stubs-x64.cc:4395: __ movp(array_map,
FieldOperand(feedback, counter, times_pointer_size,
cached_map would be nicer, array_map always confuses me with map of
Array.
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4413
src/x64/code-stubs-x64.cc:4413: __ Move(receiver_map,
masm->isolate()->factory()->heap_number_map());
LoadRoot?
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4442
src/x64/code-stubs-x64.cc:4442: __ Cmp(ic_map,
masm->isolate()->factory()->heap_number_map());
CompareRoot is shorter / faster I think.
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4528
src/x64/code-stubs-x64.cc:4528: __ Cmp(FieldOperand(feedback, 0),
factory->weak_cell_map());
CompareRoot
https://codereview.chromium.org/988653003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
