Thanks guys,
I've updated the CL.
--Michael
https://codereview.chromium.org/988653003/diff/80001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/988653003/diff/80001/src/arm/code-stubs-arm.cc#newcode4467
src/arm/code-stubs-arm.cc:4467: // TODO(mvstanton): does this hold on
ARM?
On 2015/03/16 10:30:17, Benedikt Meurer wrote:
I guess it does not matter.
Okay, I removed the TODO for now. Certainly there will be more looks at
this code in future.
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4389
src/x64/code-stubs-x64.cc:4389: __ cmpp(length, Immediate(2));
On 2015/03/16 11:39:54, Toon Verwaest wrote:
cmpl, since SmiToInteger32 above does movl of the payload
Done.
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4392
src/x64/code-stubs-x64.cc:4392: __ movp(counter, Immediate(2));
On 2015/03/16 11:39:54, Toon Verwaest wrote:
perhaps there's a shorter sequence to get a 0-extended 2?
I looked into stuff, and movl(...) offers 6 bytes, which is the same as
xorl(), movb(), the smallest yet correct sequence I could find. movl()
is okay because the 32 bit operation clears the upper bits (whereas
movb() sadly doesn't :p).
I looked into changing registers around...rdi usage here can save a
byte, but the overall code size increases if I take rdi away from it's
current purpose (feedback value). And the other non-extended registers
are all busy with the LOAD_IC convention. It stands to reason that
playing with that too much would increase code size elsewhere.
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4395
src/x64/code-stubs-x64.cc:4395: __ movp(array_map,
FieldOperand(feedback, counter, times_pointer_size,
On 2015/03/16 11:39:54, Toon Verwaest wrote:
cached_map would be nicer, array_map always confuses me with map of
Array.
Done.
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4413
src/x64/code-stubs-x64.cc:4413: __ Move(receiver_map,
masm->isolate()->factory()->heap_number_map());
On 2015/03/16 11:39:54, Toon Verwaest wrote:
LoadRoot?
Done.
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4442
src/x64/code-stubs-x64.cc:4442: __ Cmp(ic_map,
masm->isolate()->factory()->heap_number_map());
On 2015/03/16 11:39:54, Toon Verwaest wrote:
CompareRoot is shorter / faster I think.
Done.
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4442
src/x64/code-stubs-x64.cc:4442: __ Cmp(ic_map,
masm->isolate()->factory()->heap_number_map());
On 2015/03/16 11:39:54, Toon Verwaest wrote:
CompareRoot is shorter / faster I think.
Done.
https://codereview.chromium.org/988653003/diff/80001/src/x64/code-stubs-x64.cc#newcode4528
src/x64/code-stubs-x64.cc:4528: __ Cmp(FieldOperand(feedback, 0),
factory->weak_cell_map());
On 2015/03/16 11:39:54, Toon Verwaest wrote:
CompareRoot
Done.
https://codereview.chromium.org/988653003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
