LGTM
Re: spec, I think your interpretation is correct (as far as I can tell
after a
10 min reading session).
Which duplicate code are you talking about, since you removed the template
token
handling from ParseLeftHandSideExpression? In any case, this CL doesn't
seem to
be making anything worse.
https://codereview.chromium.org/996223003/diff/80001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/996223003/diff/80001/src/preparser.h#newcode2713
src/preparser.h:2713: // new tag`a` -> new(tag`a`)
Pls move this comment up in the comment block, it's more discoverable
there.
https://codereview.chromium.org/996223003/diff/80001/src/preparser.h#newcode2806
src/preparser.h:2806: // Parses this part of MemberExpression:
You probably need to change the comment in ParseMemberExpression too
https://codereview.chromium.org/996223003/diff/80001/test/mjsunit/harmony/templates.js
File test/mjsunit/harmony/templates.js (right):
https://codereview.chromium.org/996223003/diff/80001/test/mjsunit/harmony/templates.js#newcode547
test/mjsunit/harmony/templates.js:547: this.x = x === void 0 ? null : x;
What's the added value of storing this.x, since we already log.push(x) ?
https://codereview.chromium.org/996223003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
