https://codereview.chromium.org/996223003/diff/80001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/996223003/diff/80001/src/preparser.h#newcode2713
src/preparser.h:2713: // new tag`a` -> new(tag`a`)
On 2015/03/12 11:43:35, marja wrote:
Pls move this comment up in the comment block, it's more discoverable
there.
this whole block seems to be unneeded, since
ParseMemberExpressionWithNewPrefixes parses the templates on its own.
Just removing from parseLHS seems to have been enough
https://codereview.chromium.org/996223003/diff/80001/test/mjsunit/harmony/templates.js
File test/mjsunit/harmony/templates.js (right):
https://codereview.chromium.org/996223003/diff/80001/test/mjsunit/harmony/templates.js#newcode547
test/mjsunit/harmony/templates.js:547: this.x = x === void 0 ? null : x;
On 2015/03/12 11:43:35, marja wrote:
What's the added value of storing this.x, since we already log.push(x)
?
it's distinct because only the one which is actually called as a
constructor will have a valid "this"
https://codereview.chromium.org/996223003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
