On 2015/03/18 13:31:40, caitp wrote:
On 2015/03/18 13:07:26, caitp wrote:
> On 2015/03/18 10:49:39, Dmitry Lomov (chromium) wrote:
> > On 2015/03/16 13:16:21, caitp wrote:
> > > On 2015/03/16 13:08:01, caitp wrote:
> > > >
https://codereview.chromium.org/913073003/diff/270016/src/bootstrapper.cc
> > > > File src/bootstrapper.cc (right):
> > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/913073003/diff/270016/src/bootstrapper.cc#newcode1726
> > > > src/bootstrapper.cc:1726: Handle<JSGlobalObject>
> > global(JSGlobalObject::cast(
> > > > On 2015/03/16 09:42:24, Dmitry Lomov (chromium) wrote:
> > > > > This has to be under if(FLAG_harmony_reflect)
> > > >
> > > > Acknowledged.
> > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/913073003/diff/270016/src/bootstrapper.cc#newcode2100
> > > > src/bootstrapper.cc:2100: // Install references to functions of
the
> Reflect
> > > > object
> > > > On 2015/03/16 09:42:24, Dmitry Lomov (chromium) wrote:
> > > > > This should be under FLAG_harmony_reflect. Move it to
> > > > > IntitializeGlobal_harmony_reflect.
> > > >
> > > > I want these functions to be exposed to the runtime whether
Reflect is
on
> or
> > > not
> > > > (because I'd like to be able to use them for spread-calls, rather
than
the
> > > > runtime fn)
> > >
> > > Updated InitializeGlobal_harmony_reflect() --- I'd prefer that the
> references
> > > for builtins are set up either way, but one thing that might work is
just
> > adding
> > > a `|| FLAG_harmony_spreadcalls` or something later, I guess
> >
> > Sorry, I do not follow: your latest patch does not seem to
move 'intrenal
> > builtin' properties setting to IntitalizeGlobal_harmony_reflect
>
> I said, I think it would be preferable if the builtins did not require a
flag
to
> access those --- they're not exposed without the flag, but builtins
should
be
> able to use them.
>
> Very well, making the change
Actually, it seems to be problematic to make this change, unless the
snapshot
is
turned off.
Moved it to InitializeGlobal_harmony_reflect() so that it's never in the
snapshot, but that might be problematic later
https://codereview.chromium.org/913073003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
