On 2015/03/13 16:40:03, Dmitry Lomov (chromium) wrote:
https://codereview.chromium.org/913073003/diff/180001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):
https://codereview.chromium.org/913073003/diff/180001/src/x64/builtins-x64.cc#newcode1280
src/x64/builtins-x64.cc:1280: // Check the stack for overflow. We are not
trying
to catch
On 2015/03/13 15:10:37, caitp wrote:
> On 2015/03/13 09:39:09, Dmitry Lomov (chromium) wrote:
> > Please share the stack overflow check code between this and
PrepareApply
as
> well
>
> I notice that the stack overflow check is running before pushing
arguments
(and
> possibly newTarget) to the stack, so the check is really off by 1 or 2
pointers.
> Do we care about that?
We can overshoot, so just make it 2 pointers always
ia32/arm/arm64 ports are done --- it might be more like 4 pointers since
limit
and index for iterating over the arguments object are pushed too. If it's
not
exploitable to cause a stack overflow with Push instructions, it's probably
fine
to leave it
https://codereview.chromium.org/913073003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
