This is much nice, thanks! A couple of comments
https://codereview.chromium.org/913073003/diff/180001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):
https://codereview.chromium.org/913073003/diff/180001/src/x64/builtins-x64.cc#newcode1057
src/x64/builtins-x64.cc:1057: const int kIndexOffset,
These are not constants anymore, name them indexOffset, argumentsOffset
etc.
https://codereview.chromium.org/913073003/diff/180001/src/x64/builtins-x64.cc#newcode1061
src/x64/builtins-x64.cc:1061: __ movp(key, Operand(rbp, kIndexOffset));
Receiver and key must be LoadDescriptor::{Reeceiver,Name}Register, since
you use a KeyedLoadIC below.
Remove 'receiver' and 'key' arguments
https://codereview.chromium.org/913073003/diff/180001/src/x64/builtins-x64.cc#newcode1280
src/x64/builtins-x64.cc:1280: // Check the stack for overflow. We are
not trying to catch
Please share the stack overflow check code between this and PrepareApply
as well
https://codereview.chromium.org/913073003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
