Reviewers: Yang, danno, balazs.kilvady, akos.palfi.imgtec, dusmil.imgtec,
paul.l...,
https://codereview.chromium.org/1025453003/diff/1/src/mips64/assembler-mips64-inl.h
File src/mips64/assembler-mips64-inl.h (right):
https://codereview.chromium.org/1025453003/diff/1/src/mips64/assembler-mips64-inl.h#newcode199
src/mips64/assembler-mips64-inl.h:199: // Encoded internal references
are lui/ori load of 48-bit abolute address.
On 2015/03/19 18:35:42, paul.l... wrote:
typo, from my original, s/b: absolute. You might fix the original typo
too (new
line 274). Also in the assembler-mips-inl.h
Done.
https://codereview.chromium.org/1025453003/diff/1/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/1025453003/diff/1/src/serialize.h#newcode321
src/serialize.h:321: // 0x17 Unused (including 0x37, 0x57, 0x77).
On 2015/03/19 18:35:42, paul.l... wrote:
Code 0x17 is now used. I suggest you call this Misc, since that is how
code 1e
is labeled & handled.
Done.
Description:
MIPS: Fix 'MIPS: Serializer: serialize internal references via object
visitor.'
BUG=
Please review this at https://codereview.chromium.org/1025453003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+92, -76 lines):
M src/mips/assembler-mips.h
M src/mips/assembler-mips-inl.h
M src/mips64/assembler-mips64.h
M src/mips64/assembler-mips64-inl.h
M src/serialize.h
M src/serialize.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
