https://codereview.chromium.org/1025453003/diff/20001/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/1025453003/diff/20001/src/serialize.cc#newcode1837
src/serialize.cc:1837: rinfo->rmode() == RelocInfo::INTERNAL_REFERENCE
On 2015/03/19 19:16:33, yangguo wrote:
Please do not use a tertiary operator like this. I definitely prefer
sink_->Put(rinfo->rmode() == ... ? ... : ..., "InternalRef");
Or an if-else if you want to preserve the comment strings.
Done.
https://codereview.chromium.org/1025453003/diff/20001/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/1025453003/diff/20001/src/serialize.h#newcode321
src/serialize.h:321: // 0x17 Misc (including 0x37, 0x57, 0x77).
On 2015/03/19 19:16:33, yangguo wrote:
Please do not use this byte code. I'd like to reserve this in case we
add more
object spaces again. Instead, please use 0x1f below.
Done.
https://codereview.chromium.org/1025453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
