Balázs, there is one nit. I do like how you factored out the common code in
the
mips ports. I also see that x87 and ppc have not yet ported
https://codereview.chromium.org/1005183006, so we can't add these changes to
those platform ports. LGTM.
https://codereview.chromium.org/1025453003/diff/40001/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/1025453003/diff/40001/src/serialize.h#newcode333
src/serialize.h:333: // 0x1f Unused (including 0x3f, 0x5f, 0x7f).
This should now be marked as Misc
https://codereview.chromium.org/1025453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
