LGTM
http://codereview.chromium.org/435020/diff/1/2 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/435020/diff/1/2#newcode386 src/arm/fast-codegen-arm.cc:386: ASSERT(!Heap::InNewSpace(*Factory::the_hole_value())); Could you add a regression test for this? Something with a const variable in a context slot at the top level? http://codereview.chromium.org/435020/diff/1/6 File src/heap.h (right): http://codereview.chromium.org/435020/diff/1/6#newcode914 src/heap.h:914: (1 << MapWord::kMapPageIndexBits) * Page::kPageSize; On 2009/11/24 14:21:36, Lasse Reichstein wrote: > By popular demand: Make it obvious what map space is restricted by. by the amount of bits available for map page index encoding. Thanks. http://codereview.chromium.org/435020 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
