http://codereview.chromium.org/435020/diff/1/2 File src/arm/fast-codegen-arm.cc (right):
http://codereview.chromium.org/435020/diff/1/2#newcode386 src/arm/fast-codegen-arm.cc:386: ASSERT(!Heap::InNewSpace(*Factory::the_hole_value())); The code is currently unreachable since we don't fully support const variables in the fast compiler (we bail out on assignment to them). http://codereview.chromium.org/435020/diff/1/6 File src/heap.h (right): http://codereview.chromium.org/435020/diff/1/6#newcode914 src/heap.h:914: (1 << MapWord::kMapPageIndexBits) * Page::kPageSize; Guess I should add a comment to make it more obvious :) http://codereview.chromium.org/435020/diff/1/10 File src/x64/fast-codegen-x64.cc (right): http://codereview.chromium.org/435020/diff/1/10#newcode392 src/x64/fast-codegen-x64.cc:392: ASSERT(!Heap::InNewSpace(*Factory::the_hole_value())); Since the code isn't hit at all now, it's an easy typo to miss. At least we have found out why the code isn't hit (we bail out on assignment to const variables), so we know that the code is untested and can be prepared when we make it reachable. http://codereview.chromium.org/435020 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
