LGTM!
http://codereview.chromium.org/435020/diff/1/10 File src/x64/fast-codegen-x64.cc (right): http://codereview.chromium.org/435020/diff/1/10#newcode392 src/x64/fast-codegen-x64.cc:392: ASSERT(!Heap::InNewSpace(*Factory::the_hole_value())); On 2009/11/24 14:21:36, Lasse Reichstein wrote: > I can't see how we could have been hitting this at all. Thanks for fixing this along the way. I'm not sure - maybe this assertion should go away? For some reason I removed it only from IA32 + got it wrong on the other platforms!? My fault... http://codereview.chromium.org/435020 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
