LGTM! Nice comments in the code generator. The code is easy to follow.
http://codereview.chromium.org/442024/diff/2001/3002 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/442024/diff/2001/3002#newcode7059 src/ia32/codegen-ia32.cc:7059: // First and second argument are strings jump to the string add stub. "... are strings. Jump to the ..."? http://codereview.chromium.org/442024/diff/2001/3002#newcode8365 src/ia32/codegen-ia32.cc:8365: void StringAddStub::GenerateCopyAsciiCharacters(MacroAssembler* masm, You could have just one GenerateCopyCharacters and pass it an argument indicating whether the string is ascii or two-byte. http://codereview.chromium.org/442024/diff/2001/3003 File src/ia32/codegen-ia32.h (right): http://codereview.chromium.org/442024/diff/2001/3003#newcode773 src/ia32/codegen-ia32.h:773: bool string_check_; // Should the stub check whether arguments are strings? Put the comment on the line before? http://codereview.chromium.org/442024 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
