http://codereview.chromium.org/442024/diff/2001/3002 File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/442024/diff/2001/3002#newcode8242 src/ia32/codegen-ia32.cc:8242: __ j(equal, &string_add_runtime); Did you check that this is worth it? http://codereview.chromium.org/442024/diff/2001/3002#newcode8247 src/ia32/codegen-ia32.cc:8247: __ cmp(ebx, String::kMaxLength); Perhaps assert here that kMaxLength*2 fits in 32 bits. http://codereview.chromium.org/442024/diff/2001/3002#newcode8298 src/ia32/codegen-ia32.cc:8298: __ add(Operand(ecx), Immediate(SeqAsciiString::kHeaderSize - kHeapObjectTag)); What about external strings? http://codereview.chromium.org/442024 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
