LGTM. I want it for ARM too! (and 64 bit).
Would it be hard to call the string add code directly from the BinaryOpStub? Would it help? http://codereview.chromium.org/442024/diff/7001/8002 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/442024/diff/7001/8002#newcode8305 src/ia32/codegen-ia32.cc:8305: __ movzx_b(ecx, FieldOperand(ecx, Map::kInstanceTypeOffset)); Here you load the type fields again that you just loaded in likes 8285 and 8290. Can you somehow rearrange the registers to avoid this? http://codereview.chromium.org/442024/diff/7001/8002#newcode8341 src/ia32/codegen-ia32.cc:8341: __ movzx_b(ecx, FieldOperand(ecx, Map::kInstanceTypeOffset)); Same issue here. http://codereview.chromium.org/442024 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
