Very nice
https://codereview.chromium.org/938443002/diff/280001/src/harmony-spread.js
File src/harmony-spread.js (right):
https://codereview.chromium.org/938443002/diff/280001/src/harmony-spread.js#newcode32
src/harmony-spread.js:32: if (IS_NULL_OR_UNDEFINED(collection)) {
Isn't this is already tested by for-of?
https://codereview.chromium.org/938443002/diff/280001/src/preparser.cc
File src/preparser.cc (right):
https://codereview.chromium.org/938443002/diff/280001/src/preparser.cc#newcode1049
src/preparser.cc:1049: // TODO(caitp): support intrinsics
I don't think we need to support that.
https://codereview.chromium.org/938443002/diff/280001/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/938443002/diff/280001/src/x64/full-codegen-x64.cc#newcode4616
src/x64/full-codegen-x64.cc:4616: if (expr->IsSuperCall()) {
This is a bit strange/hacky. I assume this comes from
super(...args)
which we desugar to
%_ReflectConstruct(args, new.target)
?
https://codereview.chromium.org/938443002/diff/280001/test/mjsunit/harmony/spread-call-new-class.js
File test/mjsunit/harmony/spread-call-new-class.js (right):
https://codereview.chromium.org/938443002/diff/280001/test/mjsunit/harmony/spread-call-new-class.js#newcode5
test/mjsunit/harmony/spread-call-new-class.js:5: // Flags:
--harmony-spreadcalls --harmony-sloppy --harmony-classes
--harmony-classes can be removed
https://codereview.chromium.org/938443002/diff/280001/test/mjsunit/harmony/spread-call-new-class.js#newcode20
test/mjsunit/harmony/spread-call-new-class.js:20: super(...args);
Awesome!
https://codereview.chromium.org/938443002/diff/280001/test/mjsunit/harmony/spread-call-new-class.js#newcode20
test/mjsunit/harmony/spread-call-new-class.js:20: super(...args);
Maybe also add a case with `super(x, ...y)`
https://codereview.chromium.org/938443002/diff/280001/test/mjsunit/harmony/spread-call.js
File test/mjsunit/harmony/spread-call.js (right):
https://codereview.chromium.org/938443002/diff/280001/test/mjsunit/harmony/spread-call.js#newcode1
test/mjsunit/harmony/spread-call.js:1: // Copyright 2014 the V8 project
authors. All rights reserved.
2015
https://codereview.chromium.org/938443002/diff/280001/test/mjsunit/harmony/spread-call.js#newcode19
test/mjsunit/harmony/spread-call.js:19: assertEquals(3,
countArgs(..."tes"));
No need to test this many different strings.
https://codereview.chromium.org/938443002/diff/280001/test/mjsunit/harmony/spread-call.js#newcode135
test/mjsunit/harmony/spread-call.js:135: assertEquals(3,
O.countArgs(...(function*(){ yield 1; yield 2; yield 3; })()));
long line
https://codereview.chromium.org/938443002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
