On 2015/03/31 16:01:10, caitp wrote:
On 2015/03/31 15:37:18, caitp wrote:
> On 2015/03/31 12:59:30, Dmitry Lomov (chromium) wrote:
> > Let us have special intrinsics %_CallWithSpread
and %_ConstructWithSpread
> > instead of flags on a general CallRuntime node (see
> DefaultConstructorCallSuper
> > for inspiration).
>
> done --- (Super() is the only case that needed special behaviour).
>
> Unfortunately, one of the changes in the last patchset caused some
issues in
> debug builds (a bailout_id gets reused, and fails a DCHECK in
full-codegen
> l513). I'm not totally sure why the bailout id is reused, but it's
probably
> because of some UNREACHABLES() in VisitSpread() that shouldn't be
there...
I'll
> try to fix that up in a sec
hmm no, that's not what it is --- seems to be an issue with the way spread
method calls are desugared
Okay --- fixed that little issue, and nits addressed
https://codereview.chromium.org/938443002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
