Mostly just some questions
https://codereview.chromium.org/1061393002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1061393002/diff/20001/src/bootstrapper.cc#newcode630
src/bootstrapper.cc:630: JSReceiver::DeleteProperty(function,
factory()->name_string()).Assert();
So this'll put this into "slow" mode, but we don't really care since no
one will ever look at properties on this object?
https://codereview.chromium.org/1061393002/diff/20001/src/bootstrapper.cc#newcode634
src/bootstrapper.cc:634: CHECK_EQ(LookupIterator::ACCESSOR, it.state());
Seems like this could be a DCHECK_EQ just as well.
https://codereview.chromium.org/1061393002/diff/20001/src/bootstrapper.cc#newcode637
src/bootstrapper.cc:637: JSObject::SetOwnPropertyIgnoreAttributes(
So does this end up getting rid of the accessor? But it's OK because it
will never change?
https://codereview.chromium.org/1061393002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
