https://codereview.chromium.org/1061393002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1061393002/diff/20001/src/bootstrapper.cc#newcode630
src/bootstrapper.cc:630: JSReceiver::DeleteProperty(function,
factory()->name_string()).Assert();
On 2015/04/07 20:02:58, adamk wrote:
So this'll put this into "slow" mode, but we don't really care since
no one will
ever look at properties on this object?
Yes. But that is fine since the would have to extract the accessor and
use its properties. There is no valid reason to do that.
https://codereview.chromium.org/1061393002/diff/20001/src/bootstrapper.cc#newcode634
src/bootstrapper.cc:634: CHECK_EQ(LookupIterator::ACCESSOR, it.state());
On 2015/04/07 20:02:58, adamk wrote:
Seems like this could be a DCHECK_EQ just as well.
It had to be CHECK before when I was using lower level primitives. I'll
change it (if it works).
https://codereview.chromium.org/1061393002/diff/20001/src/bootstrapper.cc#newcode637
src/bootstrapper.cc:637: JSObject::SetOwnPropertyIgnoreAttributes(
On 2015/04/07 20:02:57, adamk wrote:
So does this end up getting rid of the accessor? But it's OK because
it will
never change?
Yes. But let me expand the test to make sure that writing to it fails.
https://codereview.chromium.org/1061393002/diff/20001/test/mjsunit/es6/throw-type-error-function-restrictions.js
File test/mjsunit/es6/throw-type-error-function-restrictions.js (right):
https://codereview.chromium.org/1061393002/diff/20001/test/mjsunit/es6/throw-type-error-function-restrictions.js#newcode7
test/mjsunit/es6/throw-type-error-function-restrictions.js:7:
Object.getOwnPropertyDescriptor(f, 'arguments').get;
On 2015/04/07 20:00:09, caitp wrote:
hmmm --- can this wait on crrev.com/1027283004 ? otherwise this
assertion will
have to change and it will be touching more tests unrelated to it.
Yes. I was going to wait for your more substantial change to land.
https://codereview.chromium.org/1061393002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
