On 2015/04/15 15:29:02, arv wrote:
On 2015/04/15 15:28:04, caitp wrote:
> On 2015/04/15 15:26:06, arv wrote:
> > Caitlin, can you take another look?
> >
> > I refactored this a bit to work better with your CL.
> >
> > One issue I found though is that we generate 2
different %ThrowTypeError%
> > functions so we can report different errors. The spec requires these
to be
the
> > same function. How important is the error message here?
>
> I think it's better if they use specific error messages.
>
> What if we used some hack with IdentityHash() to make sure they look
like
the
> same object?
Let me file a new bug since this is not really important for this CL.
The rest still looks good to me
https://codereview.chromium.org/1061393002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
