Sheepish confessions follow. Thanks for the feedback Michael :)
https://codereview.chromium.org/1097283003/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1097283003/diff/20001/src/compiler/ast-graph-builder.cc#newcode646
src/compiler/ast-graph-builder.cc:646: if (variable->is_this()) {
On 2015/04/21 18:13:44, Michael Starzinger wrote:
AFAICT, this is only needed for patching the receiver to the global
proxy in the
method prologue. Please don't "extend" Environment::Bind this way, but
rather
adapt BuildPatchReceiverToGlobalProxy accordingly.
I had tried to do that, but I couldn't get at
environment->values()->at(0), as it's private. I realize this is an
awful hack and something different should go in :) I guess
common()->Parameter(0) is the thing to use, then?
https://codereview.chromium.org/1097283003/diff/20001/src/compiler/ast-graph-builder.cc#newcode669
src/compiler/ast-graph-builder.cc:669: if (variable->is_this()) {
On 2015/04/21 18:13:44, Michael Starzinger wrote:
Likewise.
Acknowledged.
https://codereview.chromium.org/1097283003/diff/20001/src/compiler/ast-graph-builder.cc#newcode2676
src/compiler/ast-graph-builder.cc:2676: Node* parameter =
NewNode(common()->Parameter(i + 1), graph()->start());
On 2015/04/21 18:13:44, Michael Starzinger wrote:
If the receiver parameter has been patched, then using Patameter(0) he
is
incorrect and will use the un-patched version.
I see. Thanks, I didn't realize that. Will update with a new patch.
https://codereview.chromium.org/1097283003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
