Just a few drive-by s/CHECK/DCHECK/ nits. Overall looks good.
https://codereview.chromium.org/1097283003/diff/100001/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1097283003/diff/100001/src/scopes.h#newcode350
src/scopes.h:350: CHECK_NOT_NULL(receiver_);
These should probably be DCHECKs.
https://codereview.chromium.org/1097283003/diff/100001/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/1097283003/diff/100001/src/x64/full-codegen-x64.cc#newcode216
src/x64/full-codegen-x64.cc:216: CHECK_NOT_NULL(var);
Seems unnecessary since receiver() already has this check and the next
line will crash anyway; if you want to keep it please change to DCHECK.
https://codereview.chromium.org/1097283003/diff/100001/src/x64/full-codegen-x64.cc#newcode2996
src/x64/full-codegen-x64.cc:2996: CHECK_NOT_NULL(this_var);
DCHECK
https://codereview.chromium.org/1097283003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
