On 2015/04/22 15:39:32, rossberg wrote:
LGTM, but Dmitry should perhaps also have a second eyeball on the scoping
matters.
https://codereview.chromium.org/1097283003/diff/80001/src/contexts.cc
File src/contexts.cc (right):
https://codereview.chromium.org/1097283003/diff/80001/src/contexts.cc#newcode261
src/contexts.cc:261: // A with context will never bind "this".
Do we have a test for this?
There are a few:
* tests that reference "this" through a with that has no "this" property
* tests that reference "this" through a with that has a proxy
This patch adds some tests through "with" objects with "this" properties.
Dunno
if there are more cases to cover, though.
https://codereview.chromium.org/1097283003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
