https://codereview.chromium.org/1105693002/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1105693002/diff/20001/src/heap/heap.h#newcode1478
src/heap/heap.h:1478: delete list;
On 2015/04/27 15:39:13, Erik Corry wrote:
Might we not just as well return here?
Doesn't really matter. As written, the code will be robust to accidental
duplicates.
https://codereview.chromium.org/1105693002/diff/20001/src/heap/heap.h#newcode1481
src/heap/heap.h:1481: }
On 2015/04/27 15:39:13, Erik Corry wrote:
unreachable?
Don't need it if we just allow the above.
https://codereview.chromium.org/1105693002/diff/20001/src/heap/heap.h#newcode1484
src/heap/heap.h:1484: class OptionalRelocationLock {
On 2015/04/27 15:39:13, Erik Corry wrote:
Perhaps you could spend a couple of lines of comments here on why we
would want
a lock that was optional?
Done.
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.h
File src/heap/identity-map.h (right):
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.h#newcode68
src/heap/identity-map.h:68: // Note that in general, SMIs are valid
keys, but {SMI #0} is _not_ a valid key.
On 2015/04/27 15:39:13, Erik Corry wrote:
This is a very strange API. I would either ban SMIs altogether or
move to a
tagged null pointer as the internal empty representation and allow all
SMIs.
I could solve this with a special cell for SMI #0.
The intention was mostly to be useful for real heap objects, but it
works with SMIs too.
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.h#newcode86
src/heap/identity-map.h:86: V* Find(Handle<Object> handle) {
On 2015/04/27 15:39:13, Erik Corry wrote:
Why does this not return a handle?
Because the value type V is not a heap object. E.g. we will use this in
the compiler for Node* pointers to canonicalize constants.
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.h#newcode91
src/heap/identity-map.h:91: void Set(Handle<Object> handle, V value) {
On 2015/04/27 15:39:13, Erik Corry wrote:
handle should be called key? Also several other places?
Done.
https://codereview.chromium.org/1105693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
