https://codereview.chromium.org/1105693002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1105693002/diff/60001/src/heap/heap.h#newcode1456
src/heap/heap.h:1456: struct StrongRootsList {
Style nit: Please forward declare struct and the two methods below in
the .h file and move the definition of the struct and the
implementations of the methods to the .cc file.
Also since it's a struct and all fields are public, you don't need the _
suffix on their names.
https://codereview.chromium.org/1105693002/diff/60001/src/heap/heap.h#newcode1504
src/heap/heap.h:1504: explicit OptionalRelocationLock(Heap* heap, bool
concurrent)
You don't need explicit here.
https://codereview.chromium.org/1105693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
